Moderne reposted this
Co-founder @ Moderne | Java Champion | founder OpenRewrite - OSS automated refactoring
One more comment about SonarQube like issues... We wire a set of #OpenRewrite recipes that represent our team’s best practices through a GitHub action to our PR workflows, so that many of these remediations pop up as commit suggestions on net new code. In particular this GitHub action uses Moderne CLI to do its work so that no modification need be made to the beneficiary repository. This both keeps the code from regressing from an improved state and also helps teach new colleagues what we expect. An example from a PR recently: https://lnkd.in/eutrw6rg
Recently I migrated JUnit 4 to Junit 5 using OpenRewrite provided receipe. Worked fine, but SonarQube report stated JUnit 5 test classes should be package level access and tst methods need not be public access. I thought the migration will cover the sonar reported issues remediation as well. Any suggestions on this regard.
Cool - but is it really educational not providing comment on why the change is requested ? Just assuming those who wrote it originally will know why "test" isn't needed making harder to lookup with a regular find ? :)