-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get RSS and %CPU for Windows #1023
Conversation
Doesn't Lines 48 to 49 in c22fe12
Lines 426 to 427 in c22fe12
I believe Windows can use this line as well as the other platform, so Line 430 in c22fe12
|
rqd/rqd/rqmachine.py
Outdated
pids = [frame.pid for frame in list( | ||
filter(lambda frame: frame.pid > 0, values) | ||
)] | ||
# pylint: disable=E1101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the name of the rule being disabled instead of the ID -- IMO it makes it more easily understood and is consistent with the rest of the code. I think this one is no-member
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to disable=no-member
elif platform.system() == "Windows": | ||
winpsIsAvailable = False | ||
try: | ||
import winps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do users need to perform any steps to install winps
? Or it's just loaded directly from the source directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, users who are using source code need to install it using setup.py
if they want to use the module on Windows.
cd rqd/winps
python setup.py install
If OpenCue supports PyPI, it can be installed automatically with RQD dependencies.
winps
) to traverse process tree of each frame to get RSS (WorkingSetSize
) and %CPU (the same way as Linux with /proc). The code path will be disabled if the native module is not available.__updateGpuAndLlu
) from Linux and Windows