fixes to make spring boot application run on DevAppServer #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
commented
Nov 17, 2023
| for (URL url : toAdd) | ||
| { | ||
| if (libs.contains(url)) | ||
| continue; |
There was a problem hiding this comment.
@janbartel i either need this fix or the one from jetty/jetty.project#10902 to get this working.
The ContainerIncludeJarPattern is matching the duplicate jars from the libs array which adds them as container resource and this is causing problems.
Thoughts?
There was a problem hiding this comment.
@lachlan-roberts seems to me that DevAppServerClassLoader shouldn't be adding duplicate jars, so stopping it at the source is the best way. Any change to jetty is a backup to that. Of course, doesn't stop the same jar being present in 2 different locations and thus added twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.