Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomCraft2 ~ New Feature: Modified Foods #143

Merged
merged 6 commits into from
Sep 17, 2022
Merged

Conversation

PrimeSonic
Copy link
Owner

@PrimeSonic PrimeSonic commented Sep 16, 2022

Adds a new entry type ModifiedFoods for changing the Food and Water values of existing Eatable items.
Currently defaults all modified foods to not decompose.


CustomCraft2SML_1-11-0_SN1.zip
built from 275d102

Adds a new entry type 'ModifiedFoods' for changing the 'Food' and 'Water' values of existing Eatable items.
Currently defaults all modified foods to not decompose.
@PrimeSonic PrimeSonic self-assigned this Sep 16, 2022
@PrimeSonic PrimeSonic added the Enhancement New feature or request label Sep 16, 2022
@PrimeSonic PrimeSonic changed the title New Feature: Modified Foods CustomCraft2 ~ New Feature: Modified Foods Sep 16, 2022
Correction to tutorial text
@PrimeSonic PrimeSonic removed the request for review from MrPurple6411 September 16, 2022 17:46
@EldritchCarMaker
Copy link
Collaborator

is the unityengine.coremodule.dll file intended to be included in the zip file? I can't really see why it would be included there.
image

@EldritchCarMaker
Copy link
Collaborator

is there supposed to be a modified foods sample file in the sample files folder? Cause if so I'm not seeing one.

@PrimeSonic
Copy link
Owner Author

is the unityengine.coremodule.dll file intended to be included in the zip file? I can't really see why it would be included there. image

It was not. Will fix.

@PrimeSonic
Copy link
Owner Author

is there supposed to be a modified foods sample file in the sample files folder? Cause if so I'm not seeing one.

There should be. Will add.

@EldritchCarMaker
Copy link
Collaborator

other than those two, seems to work. Will test a tiny bit more to make sure, but I can't see it encountering any other problems.

it originally checked for max food value a second time, rather than checking for water value
Copy link
Collaborator

@EldritchCarMaker EldritchCarMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems all good from what I can tell

Copy link
Collaborator

@EldritchCarMaker EldritchCarMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only thing I could possibly see being added for now would be comments in the two new sample file, but it's also very self explanatory and simple so I can't see it being an issue in the slightest.

@PrimeSonic PrimeSonic merged commit 6848622 into master Sep 17, 2022
@PrimeSonic PrimeSonic deleted the CC2/ModifiedFoods branch September 17, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
2 participants
  翻译: