Applying a Regex to trim out the dirty string patterns instead #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toebeann
commented
May 29, 2021
toebeann
commented
May 29, 2021
toebeann
commented
May 29, 2021
PrimeSonic
reviewed
May 31, 2021
PrimeSonic
reviewed
May 31, 2021
…ason to be exposing this state to be set from outside of this class.
PrimeSonic
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified a bug with the patch to
MirrorInternalLogs:When a log coming from a
BepInEx.Logging.ManualLogSourcecomes in directly after one of the mid string trims applied in the patch (e.g. "(Filename: xdgodkdgx)", the patch unfortunately appears to trim both the intended line + the line coming from theManualLogSource, and leaves an empty line behind.Evidence of this occurring is in the Fast Loading Screen mod. The current release version of QMM for SN.STABLE leaves behind a large amount of empty lines after loading into the game, and Fast Loading Screen's logs are absent.
With the modifications I have made to this patch - which use a
Regexto strip out occurrences of the intended string - results in the intended behaviour: the garbage line is removed, but no other logs are affected. I have attached an SN.STABLE build of QMM installer from this branch for your testing.QModManager_4.1.3_Subnautica_Setup.exe.zip