-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetcaster] Adding SupportingPaneScaffold to Home #1303
Conversation
it looks like there's a padding between the 2 panes. can we remove that? |
Yep, I noticed that as well. Will remove. EDIT: I think we actually want this spacing as calculated by the default |
7b471d2
to
49933d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On tablet in landscape, I see a back arrow icon in the supporting pane after tapping on a podcast. Tapping this icon does nothing while in landscape, so it would be good to remove it -- happy to do that in a follow up PR if you prefer
@@ -103,30 +111,66 @@ import kotlinx.collections.immutable.PersistentList | |||
import kotlinx.collections.immutable.toPersistentList | |||
import kotlinx.coroutines.launch | |||
|
|||
@OptIn(ExperimentalMaterial3AdaptiveApi::class) | |||
@Composable | |||
fun Home( | |||
navigateToPodcastDetails: (PodcastInfo) -> Unit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Studio says this parameter is no longer used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in afe8af7
Yeah another PR would be great. I think the top bar should be hidden altogether when showing two panes |
Adding
SupportingPaneScaffold
to the home screen of Jetcaster.Remaining TODOs:
Screen_recording_20240329_162553.webm