-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asus Aura Implementation 02 #1916
Conversation
(multiple devices seem to hog the thread...)
# Conflicts: # Project-Aurora/Project-Aurora/Devices/DeviceManager.cs # Project-Aurora/Project-Aurora/Project-Aurora.csproj
device.Stop(); | ||
|
||
devices.Clear(); | ||
AuraSdk.ReleaseControl(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the aurasdk is not installed the AuraSdk.ReleaseControl(0); is going to fail, so can you change to AuraSdk?.ReleaseControl(0);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good pickup
Could you add support for asus scope(sdk name: Charm), the sdk keycodes are not working for the ctrl and windows key, and the asus sdk not supporting the uk layout just the us one, |
I'll look into it, I have Strix Flare. The internal name for it is also charm :/ |
Hi, can't seem to get my Claymore to work using the build generated by AppVeyor... |
# Conflicts: # Project-Aurora/Project-Aurora/Project-Aurora.csproj # Project-Aurora/Project-Aurora/Settings/Control_Settings.xaml.cs
@xQwexx I added the RIGHT_WINDOWS key (on my keyboard it's FN), but the ctrl codes seem to match so im now sure what's going on there |
@jdcmarques That might be because of your version of Aura that is installed. There is a guide to get that correctly setup on the Discord channel #asus-aura on the Aurora Discord Server. |
So there is two thing first sdk hashcodes not support the uk layout so DeviceKeys.HASHTAG and DeviceKeys.BACKSLASH_UK not working so you need to set them manually, like this.
Secondly asus strix scope support, because of the bigger left shift the left window and alt are not in the right place, which are not corrected by the sdk.
Side notes:
|
Add Asus strix scope and uk layout support
# Conflicts: # Project-Aurora/Project-Aurora/Project-Aurora.csproj
…rora into dev-aura-02
# Conflicts: # Project-Aurora/Project-Aurora/Project-Aurora.csproj
I just get can't find aura SDK and I have to idea where to get it I can only find aura creator on my pc |
This pull request proposes the following changes:
Known issues/To do: