Overrides restyle #1972
Merged
Overrides restyle #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol()` on IEvaluatable. An inherited attached application property has been added which can be used to pass an application context down through the visual tree of the nested nodes. This fixes issues where the application context is not applied properly and variable lists don't appear. No more having to manually forward the application down to child evaluatables. Logic for checking for a valid path has been moved into the GameStateParameterPicker, so this logic can be removed from all evaluatables and the code-behind for all layer controls where this was done. On the downside, Evaluatables no longer know their own application, though I couldn't think of an actual use case where they'd need to anymore.
Only done the core dragging system so far, still need to add the toolbox.
Removes some margins from some of the evals and generally reduces the amount of "stuff" on the controls.
…x as "templates". These are saved in the global config and are available to every application. Note that game state variable paths (excluding LocalPCInfo) are cleared if they are moved to a different application. Also added a reusabale text prompt window.
Made textbox autofocus, made it submit on enter keypress, made description and error collapse when empty, increased font size.
Made the toolbox sort tabs by the order the tabs are defined, then sort evaluatables by name.
Removed some redundant code in many of the layers' code that queries the profile parameter.
But by god it's ugly. :S Animation rewrite when. Also fixed bug where it would not always create a new boolean evaluatable when required.
…o paths sharing the first part of the name. (E.G. CPU and CPUUsage).
Thank DrMeteor for the idea. Also made the display name of the parameters get converted to space case.
diogotr7
approved these changes
Apr 23, 2020
This was referenced Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the overrides system from being based on dropdowns to a drag-drop system.
From a technical standpoint, the
SetApplicationmethod has been removed from the evaluatables, since most did not actually need to use the application context (only the ones that presented the user with the ability to choose a game state variable).Instead, an inherited attached property has been added which is set at the root level of the override editor. This property is then automatically propogated down to other controls in the logical tree and when a variable picker needs to be used it can access it through this attached property instead. This has fixed issues with manually propogating it, such as #1927.
This PR also adds a new control for allowing picking of game state variables, saving all layers from having to manually populate a dropdown box.
Finally, this PR also adds some new evaluatables: