Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous fixes #1983

Merged
merged 9 commits into from
Apr 28, 2020
Merged

Miscellaneous fixes #1983

merged 9 commits into from
Apr 28, 2020

Conversation

Wibble199
Copy link
Collaborator

A few small fixes for some of the newer things:

  • Prevented delay evaluatable allowing negative delays.
  • Added an upper limit on the radial layer's segment count (90, which should be more than enough).
  • Marked most properties on the particle layer as overridable.
  • Fixed the particle layer's region not working properly after a preset was applied.
  • Fixed an the global region editor being not removing regions from the view when they have been externally changed (e.g. by the particle layer's presets).

Wibble199 and others added 8 commits April 25, 2020 10:31
@Wibble199
Added minimum to delay evaluatable control.
a203655
@Wibble199
Added a maximum to the radial layer's segment count.
2ee16aa 
Set at 90, which means a maximum arc of 4 degrees. Even at around 20 segements though, it's still barely noticable.
This is more to prevent people crashing it by setting a studpidly high number.
@Wibble199
Marked more properties on the particle layer as overridable.
b24a902
@Wibble199
Fixed particle layer's region not working after applying a preset.
8da180b
@Wibble199
Fixed issue with the region editor not always updating when a keysequ…
83ef471 
…ence was changed in the keysequence control by a binding.

This commit fixes the issues with a region not being removed from the layer editor when a preset is applied on the particle layer and also the issue with the checkbox not being set correctly initially on the radial layer control.
For future reference for anyone reading this: When needing custom code to run when a dependency property's value is updated, this should always be done in a dedicated changed handler, NOT the property setter method. This is because changes to bindings do not actually set the property and thus would not invoke custom code on the property setter.
@Wibble199
Fixed crash when trying to remove a null sequence from the layer editor.
a07c529
@Wibble199
Added some missing labels to the evaluatables.
4873669 
Now that there is no dropdown saying what type an evaluatable is, the labels need to make it clear instead.
@diogotr7
Added Any key held evaluatable
c1f9470
@diogotr7 diogotr7 merged commit 11d2eb9 into antonpup:dev Apr 28, 2020
@Wibble199 Wibble199 deleted the fixes/miscellaneous branch April 28, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diogotr7 diogotr7 diogotr7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wibble199 @diogotr7
  翻译：