Fail tasks in scheduler when executor reports they failed #15929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32d8c0e
to
4f73511
Compare
ashb
reviewed
May 18, 2021
ashb
reviewed
May 18, 2021
4f73511
to
5e35b83
Compare
kaxil
approved these changes
May 19, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
When a task fails in executor while still queued in scheduler, the executor reports this failure but scheduler doesn't change the task state resulting in the task being queued until the scheduler is restarted. This commit fixes it by ensuring that when a task is reported to have failed in the executor, the task is failed in scheduler
5e35b83
to
9f402e2
Compare
ephraimbuddy
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 26, 2021
When a task fails in executor while still queued in scheduler, the executor reports this failure but scheduler doesn't change the task state resulting in the task being queued until the scheduler is restarted. This commit fixes it by ensuring that when a task is reported to have failed in the executor, the task is failed in scheduler
jhtimmins
pushed a commit
that referenced
this pull request
Aug 5, 2021
When a task fails in executor while still queued in scheduler, the executor reports this failure but scheduler doesn't change the task state resulting in the task being queued until the scheduler is restarted. This commit fixes it by ensuring that when a task is reported to have failed in the executor, the task is failed in scheduler (cherry picked from commit deececc)
This was referenced Aug 10, 2021
jhtimmins
pushed a commit
that referenced
this pull request
Aug 13, 2021
When a task fails in executor while still queued in scheduler, the executor reports this failure but scheduler doesn't change the task state resulting in the task being queued until the scheduler is restarted. This commit fixes it by ensuring that when a task is reported to have failed in the executor, the task is failed in scheduler (cherry picked from commit deececc)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
When a task fails in executor while still queued in scheduler, the executor reports this failure but scheduler doesn't change the task state resulting in the task being queued until the scheduler is restarted. This commit fixes it by ensuring that when a task is reported to have failed in the executor, the task is failed in scheduler (cherry picked from commit deececc)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
When a task fails in executor while still queued in scheduler, the executor reports this failure but scheduler doesn't change the task state resulting in the task being queued until the scheduler is restarted. This commit fixes it by ensuring that when a task is reported to have failed in the executor, the task is failed in scheduler (cherry picked from commit deececc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task fails in executor while still queued in scheduler, the executor reports
this failure but scheduler doesn't change the task state resulting in the task
being queued until the scheduler is restarted. This commit fixes it by ensuring
that when a task is reported to have failed in the executor, the task is failed
in scheduler
This can be reproduced with CeleryExecutor in breeze
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.