Disable direct buffer mapping mode for Resident Evil games #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could be a good idea to see if the issue also affects RE6. It was the last RE game to use the MT Framework engine, same as all the RE games on this list. |
It does, K0bin is already working on it |
GloriousEggroll
added a commit
to GloriousEggroll/proton-ge-custom
that referenced
this pull request
Jan 29, 2022
|
Should the option be added to dxvk.conf? |
|
It's not something a user should ever touch, so probably not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2453
Fixes #2084
Fixes #2266
RE games lock the same D3DPOOL_DEFAULT + D3DUSAGE_DYNAMIC buffer every frame. DXVK chooses MAP_MODE_DIRECT for it, so all our measures to prevent stalling in
Lockdon't apply here and the game syncs with the GPU every frame.I'd personally just get rid of MAP_MODE_DIRECT but @Joshua-Ashton told me on Discord to make this an option instead.
This will have to be rebased against #2157 if that PR is merged first.