-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overwriting of target attribute of anchors rendered by IPython.display #7215
Fix overwriting of target attribute of anchors rendered by IPython.display #7215
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! The CI failure looks unrelated, so I kicked it.
Thanks again @kavishdahekar, and congratulations on your first JupyterLab PR! |
Thanks @blink1073 :) Looking forward to contributing more to the project. |
@meeseeksdev backport to 1.x |
…nchors rendered by IPython.display
…5-on-1.x Backport PR #7215 on branch 1.x (Fix overwriting of target attribute of anchors rendered by IPython.display)
Bug fix for issue where user provided value for target attribute of anchor tags rendered by IPython.display were overwritten by '_blank' or '_self'.
References
Fixes #6827
Code changes
The bugfix will overwrite the
target
attribute only if it was not set.Setting of the
rel
attribute tonoopener
moved to separate if block.User-facing changes
Users rendering anchor elements using IPython.display will be able to set custom values for "target" attribute.
Backwards-incompatible changes