<format>: parameter name consistency: _First/_Last vs _Begin/_End
#1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sorry for causing a mess there, I was having some trouble using the clang-format tool for the first time. Again, all I did was change the |
CaseyCarter
requested changes
Jun 2, 2021
added 2 commits
June 3, 2021 08:33
|
@CaseyCarter Done. |
barcharcraz
approved these changes
Jun 10, 2021
|
Thanks for improving codebase consistency - and congratulations on your first microsoft/STL commit! 🎉 😸 🚀 This will ship in VS 2022 17.0 Preview 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances #1947. All
_Beginand_Endparameters have been changed to_Firstand_Last, respectively. There is also a function on line 2081 (_Write_separated_integer) which uses the parameter names_Startand_End, so I edited that function too conforming to the standard parameter names.