-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the feature-test macro for P2162R2 for variant #2006
Conversation
You need to also update the feature test macro test. |
Come to think of it. Considering this was implemented in C++17, thus available in that mode, shouldn't the value just be updated instead of under |
Yes. I found it when inspected failed test: "std/language.support/support.limits/support.limits.general/variant.version.pass.cpp" |
…eneral/variant.version.pass.cpp
Do we have test coverage for that to ensure we never accidentally degrade it? |
tests/std/tests/P2162R2_std_visit_for_derived_classes_from_variant/env.lst
Outdated
Show resolved
Hide resolved
tests/std/tests/P2162R2_std_visit_for_derived_classes_from_variant/test.cpp
Show resolved
Hide resolved
tests/std/tests/P2162R2_std_visit_for_derived_classes_from_variant/test.cpp
Show resolved
Hide resolved
tests/std/tests/P2162R2_std_visit_for_derived_classes_from_variant/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2162R2_std_visit_for_derived_classes_from_variant/test.cpp
Show resolved
Hide resolved
tests/std/tests/P2162R2_std_visit_for_derived_classes_from_variant/test.cpp
Show resolved
Hide resolved
Co-authored-by: Casey Carter <Casey@Carter.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll push a couple of trivial test changes for style/comment issues I noticed.
tests/std/tests/P2162R2_std_visit_for_derived_classes_from_variant/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2162R2_std_visit_for_derived_classes_from_variant/test.cpp
Outdated
Show resolved
Hide resolved
Thanks for looking into this and adding test coverage - one step closer to C++23 completeness! 🎉 😸 ✔️ |
Fixes #1683