Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xloctime: do_put shouldn't modify errno on success #2049

Merged
merged 10 commits into from
Jul 1, 2022
Merged

xloctime: do_put shouldn't modify errno on success #2049

merged 10 commits into from
Jul 1, 2022

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Jul 8, 2021

Fixes #2045

@fsb4000 fsb4000 requested a review from a team as a code owner July 8, 2021 15:37
@fsb4000 fsb4000 changed the title xloctime: do_put shouldn't modify errno xloctime: do_put shouldn't modify errno on success Jul 8, 2021
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Jul 9, 2021
@StephanTLavavej StephanTLavavej self-assigned this Jul 14, 2021
@StephanTLavavej StephanTLavavej added the affects redist Results in changes to separately compiled bits label Dec 15, 2021
@StephanTLavavej
Copy link
Member

Thanks! I pushed a conflict-free merge with main (as it had been a while, including a submodule update), followed by minor test changes (essentially stylistic).

The product code change looks correct and comprehensive. (And I'm not worried about testing the /Zc:wchar_t- codepath, given that it's being updated the same as real wchar_t.)

@StephanTLavavej StephanTLavavej removed their assignment May 31, 2022
@StephanTLavavej StephanTLavavej added the blocked Something is preventing work on this label Jun 1, 2022
@StephanTLavavej
Copy link
Member

Marking as blocked due to the redist impact (hopefully we will know soon when we can merge this class of PRs).

barcharcraz
barcharcraz approved these changes Jun 4, 2022
View reviewed changes
Copy link
Member

@barcharcraz barcharcraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I would ask for a test when errno does not start out as zero, but I think the current test is sufficient to catch regressions.

@StephanTLavavej StephanTLavavej removed the blocked Something is preventing work on this label Jun 29, 2022
@StephanTLavavej StephanTLavavej self-assigned this Jun 30, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 4583065 into microsoft:main Jul 1, 2022
@StephanTLavavej
Copy link
Member

Thanks for investigating and fixing this runtime correctness bug! 🐞 ✅ 😻

@fsb4000 fsb4000 deleted the fix2045 branch July 1, 2022 04:16
fsb4000 added a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@fsb4000 @StephanTLavavej
xloctime: do_put shouldn't modify errno on success (microsoft#2049)
a58914c 
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barcharcraz barcharcraz barcharcraz approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
affects redist Results in changes to separately compiled bits bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

put_time leaves errno set to ERANGE on success
3 participants
@fsb4000 @StephanTLavavej @barcharcraz
  翻译：