Avoid "friends of friends" (CWG1699) in common_iterator
#2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CWG consensus is that friend functions defined inline in a class `X` should be treated as friends of classes that befriend `X`, but there's implementation divergence. (Probably because the issue has been in "drafting" for eight years.) Fixes microsoft#2065
CaseyCarter
commented
Jul 20, 2021
| template <input_or_output_iterator _OIter, sentinel_for<_OIter> _OSe> | ||
| requires (!same_as<_OIter, _OSe> && copyable<_OIter>) | ||
| friend class common_iterator; | ||
| // clang-format on |
There was a problem hiding this comment.
Note the removal of cross-specialization friendship here; I've chosen to use _Get_val consistently in both member functions and friend functions.
|
LGTM except that I am missing some test coverage |
Something funny is going on: we are somehow missing cross-type comparison coverage, but we do have cross-type difference coverage which is not failing. |
miscco
approved these changes
Jul 21, 2021
StephanTLavavej
approved these changes
Aug 10, 2021
This comment has been minimized.
This comment has been minimized.
mnatsuhara
approved these changes
Aug 13, 2021
|
I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed. |
|
Thanks for fixing this friendship bug! 😸 🎉 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CWG consensus is that friend functions defined inline in a class
Xshould be treated as friends of classes that befriendX, but there's implementation divergence. (Probably because the issue has been in "drafting" for eight years.)Fixes #2065