Workaround ExceptionFlags change in NT #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by allowing flags other than `EXCEPTION_NONCONTINUABLE` to be set by `RaiseException`. This should unblock CI on the new Server 2022 VMs, for which `RaiseException` sets a new flag indicating that the exception originated in software. (This also reproduces locally for me on Windows 11.) This mirrors the STL changes from the internal MSVC-PR-356899.
mnatsuhara
approved these changes
Oct 8, 2021
StephanTLavavej
approved these changes
Oct 8, 2021
|
Relabeling as |
|
Merging without Changelog, since (1) this is fairly obscure, and (2) we haven't had contributors on Windows 11 complain about these tests failing. |
|
Almost forgot the bad pun! Thank you for this exceptional contribution! |
RSilicon
pushed a commit
to RSilicon/STL
that referenced
this pull request
Nov 4, 2021
...by allowing flags other than `EXCEPTION_NONCONTINUABLE` to be set by `RaiseException`. This should unblock CI on the new Server 2022 VMs, for which `RaiseException` sets a new flag indicating that the exception originated in software. (This also reproduces locally for me on Windows 11.) This mirrors the STL changes from the internal MSVC-PR-356899.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by allowing flags other than
EXCEPTION_NONCONTINUABLEto be set byRaiseException. This should unblock CI on the new Server 2022 VMs, for whichRaiseExceptionsets a new flag indicating that the exception originated in software. (This also reproduces locally for me on Windows 11.)This mirrors the STL changes from the internal MSVC-PR-356899.
(Tagging this as high priority since we already merged the internal PR to unblock CI.)