Toolset update: VS 2022 17.1 Preview 1 #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Implicit copy assignment incorrectly not constexpr when subobject has explicit constexpr copy constructor"
"Standard Library Header Units: Bogus error C2440 when convertible_to constrains a constructor"
"cl does not make special member functions implicitly constexpr"
CaseyCarter
approved these changes
Nov 9, 2021
"Blocking: Send-VsDevShellTelemetry : Could not load file or assembly Newtonsoft.Json" Thanks to vitek-karas for mentioning this workaround in dotnet/runtime 60061.
This comment has been minimized.
This comment has been minimized.
AlexGuteniev
reviewed
Nov 9, 2021
CaseyCarter
approved these changes
Nov 9, 2021
miscco
approved these changes
Nov 9, 2021
CaseyCarter
approved these changes
Nov 10, 2021
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed, or if more work is required. |
MahmoudGSaleh
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_MSC_VERyet, because the MSVC-internal build is still starting with a checked-in compiler version of 19.30.VSCMD_SKIP_SENDTELEMETRYto1.build.cmdfails with latest VS 2022 dogfood dotnet/runtime#60061.provision-image.ps1, simplify how we get/set thePath.PipInstall.subrangein<xutility>is still affected by something (possibly an unfixed corner case, possibly a different bug that was hiding behind the first bug). I've filed<xutility>:subrangeis still affected by an MSVCconstexprcompiler bug #2326 to track this, and preserved the workaround in product code.