<filesystem>: __std_fs_get_stats should work on FAT32
#2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGuteniev
reviewed
Dec 3, 2021
AlexGuteniev
approved these changes
Dec 4, 2021
BillyONeal
reviewed
Jan 6, 2022
|
DevCom-1638272 with the same issue. |
strega-nil-ms
approved these changes
May 3, 2022
There was a problem hiding this comment.
I have looked this over (with a pen and paper to make sure I understood the function!) and I believe this to be a correct and good change. I also had billy look over my shoulder at it, and he didn't have any major problems.
My one concern was adding an extra function call when checking only for reparse point data, but given that we have multiple calls to GetFileInformationByHandleEx anyways, and the call is quite cheap, I'm no longer concerned.
Thanks!
On the other hand, in a typical case, when it is not a reparse point, the number of calls is the same; actually when checking not only for RP a call is saved. |
StephanTLavavej
approved these changes
May 4, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this most modern filesystem library to work with this most ancient filesystem! 😹 🎉 🚀 |
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Oct 9, 2023
MSVC's `std::filesystem` has a bug that causes it to fail to retrieve file information on exFAT partitions in versions prior to (roughly) 17.2. That version is the first release after merging a fix from microsoft/STL#2373, but I'm not certain that version has the fix included. Using `std::filesystem::status` instead of `symlink_status()` seems justified because exFAT paritions don't support symlinks. If other partition types are included in the filter for error code 87, this may need to be revisited.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Oct 9, 2023
MSVC's `std::filesystem` has a bug that causes it to fail to retrieve file information on exFAT partitions in versions prior to (roughly) 17.2. That version is the first release after merging a fix from microsoft/STL#2373, but I'm not certain that version has the fix included. Using `std::filesystem::status` instead of `symlink_status()` seems justified because exFAT paritions don't support symlinks. If other partition types are included in the filter for error code 87, this may need to be revisited.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Oct 10, 2023
MSVC's `std::filesystem` has a bug that causes it to fail to retrieve file information on exFAT partitions in versions prior to (roughly) 17.2. That version is the first release after merging a fix from microsoft/STL#2373, but I'm not certain that version has the fix included. Using `std::filesystem::status` instead of `symlink_status()` seems justified because exFAT paritions don't support symlinks. If other partition types are included in the filter for error code 87, this may need to be revisited.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Oct 10, 2023
MSVC's `std::filesystem` has a bug that causes it to fail to retrieve file information on exFAT partitions in versions prior to (roughly) 17.2. That version is the first release after merging a fix from microsoft/STL#2373, but I'm not certain that version has the fix included. Using `std::filesystem::status` instead of `symlink_status()` seems justified because exFAT paritions don't support symlinks. If other partition types are included in the filter for error code 87, this may need to be revisited.
ericmehl
added a commit
to ericmehl/gaffer
that referenced
this pull request
Oct 19, 2023
MSVC's `std::filesystem` has a bug that causes it to fail to retrieve file information on exFAT partitions in versions prior to (roughly) 17.2. That version is the first release after merging a fix from microsoft/STL#2373, but I'm not certain that version has the fix included. Using `std::filesystem::status` instead of `symlink_status()` seems justified because exFAT paritions don't support symlinks. If other partition types are included in the filter for error code 87, this may need to be revisited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233