-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strike "with concepts support" from the GH-1814 messages #2382
Strike "with concepts support" from the GH-1814 messages #2382
Conversation
Our supported C++latest frontends (clang-cl and msvc) both have concepts support, so this appears redundant. Fixes DevCom-1603100
I don't understand - we support EDG in c++latest mode, but it lacks full support for concepts, so we exclude format/ranges/etc. Is the theory here that because we treat EDG-for-STL-testing and EDG-for-IntelliSense differently (where we activate concepts anyways, by special request), that users are confused by the "with concepts support" part? If so, this change would make sense to me, but I think the PR description should mention this. |
The issue is that C++20 has been published, so today "C++latest" means "support for C++ beyond C++20." The set of compilers that support C++20 and Concepts is the same as the set that supports C++20, so "C++latest and Concepts" is redundant. The fact that EDG-for-STL-testing doesn't fully support C++20 is enough to rule it out of "C++latest" even absent a specific "and concepts" requirement. |
Ok, thanks for explaining. I think we have different interpretations of what "c++latest mode" means (to me, EDG-for-STL-testing supports a |
I think my interpretation is actually closer to yours, I'm projecting here what I believe to be a very common customer perspective that this particular DevCom submitter represents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update #2061 similarly when your PR will be merged.
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for improving these diagnostics! 📖 💡 😸 |
Our supported C++latest frontends (clang-cl and msvc) both have concepts support, so this appears redundant.
Fixes DevCom-1603100
Closes VSO-1445646 / AB#1445646