-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix begin/end for valarray crashing on empty instance #2435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to apply my suggestions which clean up pre-existing weirdness in <valarray>
.
There's no reason to make friend declarations private.
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for fixing this bug - and congratulations on your first microsoft/STL commit! 🎉 😻 🚀 This will ship as part of VS 2022 17.2 Preview 2. |
This issue also causes range-based for loops to break for empty valarrays.
I also added regression tests, which I hope are fine.
If there's anything wrong just tell me and I'll happily adjust!