Implement P2273R3 constexpr unique_ptr
#2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2273R3_constexpr_unique_ptr/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Mar 3, 2022
|
Thanks! The product code looked perfect, couldn't find even a single nitpick. 😻 Had a few suggestions for the test, but they were all tiny, so I went ahead and pushed changes for them. |
|
Wait unique_ptr is now constexpr? nice. |
barcharcraz
approved these changes
Mar 12, 2022
StephanTLavavej
approved these changes
Mar 15, 2022
|
I've pushed a merge with I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for implementing and carefully testing this feature! 🚀 ✅ 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2535
I added tests and they pass with
clang-cland fail withcl.exeandEDG:((The test now contains workarounds citing DevCom-1436243 and DevCom-1670927.)