Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[validate] add validate cmake target #2697

Merged
merged 11 commits into from
May 5, 2022

Conversation

strega-nil-ms
Copy link
Contributor

additionally deletes jobify project

This is a follow-up to #2671

additionally deletes validate project
@strega-nil-ms strega-nil-ms requested a review from a team as a code owner May 3, 2022 00:17
@CaseyCarter CaseyCarter added the infrastructure Related to repository automation label May 3, 2022
tools/CMakeLists.txt Outdated Show resolved Hide resolved
tools/CMakeLists.txt Outdated Show resolved Hide resolved
tools/validate/CMakeLists.txt Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

As we discussed in person, I pushed two changes:

  • Simplify target_compile_options in tools/validate/CMakeLists.txt.
  • Simplify azure-pipelines.yml. We can rely on the implicit behavior of stop-on-failure because of how your new steps behave:
    • If format-validate-build fails (e.g. if validate.cpp has been damaged), which is extremely unlikely, then we won't try to run-format or run-validate. ('Create Diff' will run because succeededOrFailed() but it won't find any differences.)
    • The behavior of run-format is to succeed even when it generates a diff, which will allow run-validate to proceed. (If it fails because clang-format crashes horribly or whatever, that's unlikely and it's okay if that prevents run-validate.)
    • If run-validate fails, 'Create Diff' will still get to run due to succeededOrFailed().

I verified the behavior of simultaneous clang-format and validate failure in #2701.

@StephanTLavavej StephanTLavavej self-assigned this May 5, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 8999b68 into microsoft:main May 5, 2022
@StephanTLavavej
Copy link
Member

Thanks for further improving how we build and run the format and validate checks! ✅ 😺 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
  翻译: