STL.natvis: add specializations for shared_ptr<void>, weak_ptr<void>, and unique_ptr<void, deleter>
#2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared_ptr<void> and weak_ptr<void>shared_ptr<void>, weak_ptr<void> and unique_ptr<void, deleter>
We could tag the problematic part of the original visualizer Optional, but the result would be less than ideal. I don't know how to otherwise avoid this duplication. |
CaseyCarter
approved these changes
May 4, 2022
CaseyCarter
approved these changes
May 4, 2022
shared_ptr<void>, weak_ptr<void> and unique_ptr<void, deleter>shared_ptr<void>, weak_ptr<void>, and unique_ptr<void, deleter>
CaseyCarter
reviewed
May 22, 2022
| @@ -288,6 +288,16 @@ SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
| </Type> | |||
|
|
|||
| <!-- VC 2015 --> | |||
| <Type Name="std::unique_ptr<void, *>"> | |||
There was a problem hiding this comment.
I've pulled these changes into internal VS-PR-400483. Please notify me of any changes to this file.
There was a problem hiding this comment.
I'll add this to the MSVC-PR mirror too.
There was a problem hiding this comment.
May as well. I don't plan to include the "big" visualizer PR. I won't have time to review it today, expected is taking an ... unexpectedly long time to review. 😎
|
Thanks for fixing these visualizers! 😸 👁️ 🎉 |
fsb4000
added a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
…d>`, and `unique_ptr<void, deleter>` (microsoft#2706)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2688
It works, but perhaps there is an option without the duplication...