Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMakeLists.txt] add more information to the /Os transition comment #2708

Merged
merged 3 commits into from
May 5, 2022
Merged

[CMakeLists.txt] add more information to the /Os transition comment #2708

merged 3 commits into from
May 5, 2022

Conversation

strega-nil-ms
Copy link
Contributor

I am looking at the CMake build, and was investigating whether it was worth it to remove /Os from the release flags. I do not believe it is, but maybe if the performance numbers are staggering it could be.

@strega-nil
remove transition from /Os option
315671b 
in version 19.32.31328, /Os results in binary size savings of 102K in the release DLL
(that's 15.5% savings)
@strega-nil-ms strega-nil-ms added the build Related to the build system label May 4, 2022
@strega-nil-ms strega-nil-ms requested a review from a team as a code owner May 4, 2022 22:08
@strega-nil-ms strega-nil-ms changed the title [CMakeLists.txt] remove transition comment from /Os option [CMakeLists.txt] add more information to the /Os transition comment May 4, 2022
CaseyCarter
CaseyCarter reviewed May 4, 2022
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

While I have no objection to expanding this comment, for the future I would like to recommend the approach of filing and citing a tracking issue, because we can easily add and edit comments in such an issue (and contributors can comment too), whereas changing comments in the codebase requires additional work for the PR process.

StephanTLavavej
StephanTLavavej approved these changes May 4, 2022
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this May 5, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@AlexGuteniev
Copy link
Contributor

Maybe link to #2108 ?

@AlexGuteniev
Copy link
Contributor

Note that I added override of /Os with pragma in #2434 . It was benchmark-backed: size impact was negligible, perf improvement was noticeable. It may be the way to proceed further.

@StephanTLavavej
Copy link
Member

Thanks, I forgot I filed that tracking issue. I can add a citation.

@StephanTLavavej StephanTLavavej merged commit e86c643 into microsoft:main May 5, 2022
@StephanTLavavej
Copy link
Member

Thanks for looking into this build system comment! 😺 💬 🎉

@strega-nil strega-nil deleted the remove-transition branch August 10, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@barcharcraz barcharcraz barcharcraz approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
build Related to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@strega-nil-ms @StephanTLavavej @AlexGuteniev @CaseyCarter @barcharcraz @strega-nil
  翻译：