Fix chrono printing #2814
Merged
Fix chrono printing #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{} is specified to be equivalent to formatting
using iostreams <<, but for very small durations
we would fail to compile such code because of conversions
to longer durations failing (since we form the hh_mm_ss structure
for all formats, even though in this case it isn't used.
This change should make some of the specifiers that _do_ use that
structure work as well (for example {:%H}, attoseconds).
This problem occurs for any chrono conversion where the source type
can not represent even one period of the target type.
7a18f08
to
c27cb81
Compare
StephanTLavavej
requested changes
Jun 22, 2022
…pecifier with time-points, as well as raw durations.
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Jul 7, 2022
|
Thanks, this looks good! I verified that the underflow check is correctly using the GCDs to reduce. I validated and pushed a conflict-free merge with |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing these user-reported compiler errors! ⏱️ 💥 😺 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
…soft#2814) Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be more cases of this behavior that are not fixed here, but this should improve things for basic formatting with {}.
There's a bunch of standardize that appears unfortunate when considering types that "underflow" in this manner, the wording tries to make sure you don't truncate when converting from large periods to tiny ones, but the reverse is also prevented, even though it's not a big deal and is similar to the "rounding" that already happens when converting from say, seconds, to days with duration_cast.
For example, chrono::ceil and chrono::floor makes sense in this case.
Fixes VSO-1521926/AB#1521926.