-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<any>
: Skip the contents when static RTTI is disabled
#3115
<any>
: Skip the contents when static RTTI is disabled
#3115
Conversation
The contents should be skipped when static RTTI is unavailable.
Co-authored-by: Casey Carter <Casey@Carter.net>
Do we want to additionally not include |
@strega-nil-ms Agreed - the intention is for |
`<algorithm>` is always included first, so `<yvals_core.h>` is available.
Also reduce the /analyze coverage to one configuration.
Ok, I've pushed the following changes (FYI @CaseyCarter @strega-nil-ms):
Thanks @frederick-vs-ja for working on this - if we're going to have this not-exactly-encouraged-but-still-supported mode, it should behave reasonably, and I think your change makes the story coherent. 😻 ✅ Note to self: modules changes verified. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for fixing the first bug after Standard Library Modules was merged! 🐞 ✅ 😻 |
Co-authored-by: Casey Carter <Casey@Carter.net> Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
This PR is making
#include <any>
effectless rather than erroneous when static RTTI is disabled.Fixes #3114.