-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement P2474R2 views::repeat
#3142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several functions should be unconditionally marked with noexcept
, since operations on integer-like types are all noexcept
, and the iterator is implemented as a trivially copyable type.
Just to be clear so I know where to pick up tomorrow when you lot (except a certain vampire) are probably asleep. The Edit: oh, didn't see the "11 comments" button 😅. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One internal constructor can't be unconditionally noexcept
.
The
noexcept
-ness shouldn't depend on the bound type at all?
I think it does depend. But the permitted set of bound types is very small (only integer-like types and unreachable_sentinel_t
), and noexcept
-ness is always hold for its elements.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Thanks! I pushed some minor changes (most notable being a slight expansion of death test coverage) and I believe that all outstanding comments have been resolved. Onwards to final review! |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks! Thanks! Thanks! Thanks! Thanks! Thanks! Thanks! Thanks! Thanks! Thanks! 😹 😹 😹 |
You can say that again. |
Fixes #2933
Some questions:
[{_Current)]
{Value}
Most of the test is reworked from the
iota_view
test, I might have removed something that should have been kept/reworked.Drive-by fixed
single_view
s visualizer, I'm assuming the intent was to wrap it in[]