Move _Rng_from_urng and _Rng_from_urng_v2 out of <xutility>
#3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility> to <random>.
barcharcraz
approved these changes
Oct 15, 2022
strega-nil-ms
approved these changes
Oct 18, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3012, the compiler team reported a 6% throughput regression. We can fix this by moving some code around, making it slightly better than it originally was.
First,
_Rng_from_urng_v2is needed only in<random>, so we can move it and its<__msvc_int128.hpp>dependency there. (According to my understanding, this dependency is the main cause of the throughput regression.)Second,
_Rng_from_urngis needed only in<algorithm>and<random>, and<random>includes<algorithm>. Therefore, we can move it to<algorithm>. (I can't remember why I originally defined it in<xutility>.) We do need to be careful to close and reopen the_HAS_CXX17guard.These are pure code movements, no other changes.
Fixes VSO-1641134.