-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Brace Lists to initialize objects. #3277
Conversation
This is for consistency.
Since we're constructing temporaries, I would prefer to see In contrast, plain |
I've pushed a merge with To summarize, the changes are:
Note: I have deliberately not audited the test code. Our test suite is relatively vast and contains lots of old code. We don't spend effort on modernizing its patterns except in unusually important cases (e.g. braces for control flow); also it is sometimes important for test code to use unusual patterns so by default it's better not to mess with them too much. We try to keep the product code more modern and consistent. |
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for these consistency improvements! 📈 😸 🎉 |
This is for consistency with the rest of the code.