Implement P2711R1 Making Multi-Param Constructors Of Views explicit
#3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: A. Jiang <de34@live.cn>
CaseyCarter
requested changes
Feb 12, 2023
| @@ -285,6 +285,7 @@ | |||
| // P2432R1 Fix istream_view | |||
| // P2508R1 basic_format_string, format_string, wformat_string | |||
| // P2520R0 move_iterator<T*> Should Be A Random-Access Iterator | |||
| // P2711R1 Making Multi-Param Constructors Of Views explicit | |||
There was a problem hiding this comment.
For other reviewers: This is in the "_HAS_CXX20 controls" section because it's being implemented back to C++20. I think that makes sense: relatively few people are using the view types now to be broken when constructors become explicit. Presumably letting more people write code that will break when moving to C++23 is worse than just breaking the early adopters immediately.
CaseyCarter
approved these changes
Feb 12, 2023
StephanTLavavej
approved these changes
Feb 12, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for implementing this feature mere hours after it was voted in! ⏳ 😻 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3448