-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanups: Formatting and comments #3523
Cleanups: Formatting and comments #3523
Conversation
Mentioning _Count is overwhelmingly more common; _Uninitialized_value_construct_n_unchecked1 in <xmemory> doesn't even take _Count_raw.
Co-authored-by: Jakub Mazurkiewicz <mazkuba3@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed two areas where we may want further changes:
- stl/inc/iterator:255: it doesn't result in the newline going away, but we could change the
// strengthened
to a/* strengthened */
before a{
(I believe it's the only one left - there are still two newlines in a row between macros in
<atomic>
Thanks @strega-nil-ms! 😻 I've pushed a conflict-free merge with |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
// strengthened
putting{
on the next line. This is one of the few scenarios where we prefer to use C-style comments.grapheme_break_property_data_gen.py
accordingly (and verified that the output is identical after clang-formatting).PROP_VALUE_ENUM_TEMPLATE.lstrip()
which is sufficient. But then I noticed thatDATA_ARRAY_TEMPLATE
was the only multi-line string template that we weren't stripping leading whitespace from, which seemed confusing. I think it's better to consistently strip them (so we can pretend that they didn't begin with leading whitespace at all), and then explicitly add a newline to separate the enumerator values from the table._Count
instead of_Count_raw
._Count
is overwhelmingly more common;_Uninitialized_value_construct_n_unchecked1
in<xmemory>
doesn't even take_Count_raw
.