Remove lower_bound()/upper_bound() from hash_meow/unordered_meow
#4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were deprecated by MSVC-PR-181971 on 2019-05-23. We can remove the tr1 test coverage because we already have exactly equivalent coverage of find() and equal_range().
CaseyCarter
approved these changes
Apr 24, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These member functions were unconditionally deprecated by MSVC-PR-181971 on 2019-05-23.
It's been almost 5 years, so it's time to remove this machinery now. Note that there is no loss of functionality - as the deprecation warnings advised, any calls can be exactly converted into
find()orequal_range().We can remove the tr1 test coverage because we already have exactly equivalent coverage of
find()andequal_range().