Low latency DASH support #979

CaitlinOCallaghan · 2021-08-17T23:54:02Z

LL-DASH Support

These changes add support for LL-DASH streaming.
While writing this feature, I have been checking in with @joeyparrish to get feedback along the way. See the original PRs here.

NOTE: LL-HLS support is still in progress, but it's coming. :)

Testing

./chunking_unittest --gtest_filter="ChunkingHandlerTest.LowLatencyDash"

./media_event_unittest --gtest_filter="MpdNotifyMuxerListenerTest.LowLatencyDash"

./mpd_unittest --gtest_filter="PeriodTest.LowLatencyDashMpdGetXml"
./mpd_unittest --gtest_filter="SimpleMpdNotifierTest.NotifyAvailabilityTimeOffset"
./mpd_unittest --gtest_filter="SimpleMpdNotifierTest.NotifySegmentDuration"
./mpd_unittest --gtest_filter="LowLatencySegmentTest.LowLatencySegmentTemplate"

Note, packager_test must be run from the main project directory
./out/Release/packager_test --gtest_filter="PackagerTest.LowLatencyDashEnabledAndUtcTimingNotSet"
./out/Release/packager_test --gtest_filter="PackagerTest.LowLatencyDashEnabledAndUtcTimingNotSet"

Documentation

googlebot · 2021-08-17T23:54:38Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-17T23:54:39Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

CaitlinOCallaghan · 2021-08-18T00:12:49Z

Hi,

I need help with the CLA agreement. I have been able to send PRs to Shaka Streamer, so I know my email cocallaghan@fb.com is valid with my company's CLA.

When I run git shortlog -e -s -n | grep "Caitlin O'Callaghan" to check my commits and associated emails I see:

Do you reckon the "@users.noreply.github.com" handle from my merges is causing an issue? I peeked in Packager's commit history and saw that other people committed/merged with the "@users.noreply.github.com" handle, and I didn't see issues with their PRs, so I'm not sure that is the problem.

kevleyski · 2021-08-18T00:20:53Z

Thanks Caitlin

kqyang · 2021-08-18T00:48:19Z

@CaitlinOCallaghan Thanks for the PR!

I checked the CLA, here is what I got:

PullRequest Sender

GitHub Login	Email	State
CaitlinOCallaghan	38890251+caitlinocallaghan@users.noreply.github.com	ok

Commit Author(s)

GitHub Login	Email	State
caitlinocallaghan	cocallaghan@fb.com	ok
caitlinocallaghan	38890251+CaitlinOCallaghan@users.noreply.github.com	need_author_cla

So yes, the problem is with 38890251+CaitlinOCallaghan@users.noreply.github.com email address.

There are two options:

Re-push the commits with the known working email address, i.e. cocallaghan@fb.com. I am not sure but 38890251+caitlinocallaghan@users.noreply.github.com might work too.
Sign another CLA with email 38890251+CaitlinOCallaghan@users.noreply.github.com.

googlebot · 2021-08-23T22:14:57Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla · 2021-08-23T22:14:58Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

joeyparrish · 2021-08-23T23:40:13Z

I need to figure out what is wrong with the PR workflow. I'll let you know when I've figured that out. You may need to rebase/merge at that point to pick up the fix.

I'll also try to give this a thorough review soon. Definitely this week.

joeyparrish · 2021-08-24T23:49:55Z

You should be able to fix the CI issues by rebasing/merging with the master branch now. Sorry for the inconvenience!

joeyparrish

Looks good!

kevleyski · 2021-08-25T00:01:18Z

Thanks Joey

…

On 25 Aug 2021, at 9:50 am, Joey Parrish ***@***.***> wrote: You should be able to fix the CI issues by rebasing/merging with the master branch now. Sorry for the inconvenience! — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

…ASH MPD

…dards

…lating it for each chunk.

CaitlinOCallaghan · 2021-08-25T00:36:00Z

@joeyparrish No worries! Thank you for the fix and approval!

joeyparrish · 2021-08-25T15:38:17Z

Woohoo! Thanks, Caitlin!

kevleyski · 2021-08-25T21:28:55Z

Thanks again @CaitlinOCallaghan great work
Much appreciated

kevleyski · 2021-08-25T23:07:04Z

packager/media/formats/mp4/segmenter.h

@@ -126,6 +126,8 @@ class Segmenter {
  virtual Status DoFinalize() = 0;
  virtual Status DoFinalizeSegment() = 0;



(minor formatting)

# LL-DASH Support These changes add support for LL-DASH streaming. **NOTE:** LL-HLS support is still in progress, but it's coming. :) ## Testing `./chunking_unittest --gtest_filter="ChunkingHandlerTest.LowLatencyDash"` `./media_event_unittest --gtest_filter="MpdNotifyMuxerListenerTest.LowLatencyDash"` `./mpd_unittest --gtest_filter="PeriodTest.LowLatencyDashMpdGetXml"` `./mpd_unittest --gtest_filter="SimpleMpdNotifierTest.NotifyAvailabilityTimeOffset"` `./mpd_unittest --gtest_filter="SimpleMpdNotifierTest.NotifySegmentDuration"` `./mpd_unittest --gtest_filter="LowLatencySegmentTest.LowLatencySegmentTemplate"` Note, packager_test must be run from the main project directory `./out/Release/packager_test --gtest_filter="PackagerTest.LowLatencyDashEnabledAndUtcTimingNotSet"` `./out/Release/packager_test --gtest_filter="PackagerTest.LowLatencyDashEnabledAndUtcTimingNotSet"`

CaitlinOCallaghan mentioned this pull request Aug 19, 2021

Low latency dash support staging shaka-project/shaka-streamer#88

Merged

joeyparrish approved these changes Aug 24, 2021

View reviewed changes

CaitlinOCallaghan added 18 commits August 24, 2021 17:16

Low lat dash control hooks to create a chunk for each media sample

3606211

Setup class to handle low latency mp4 segments

fdfb3d3

Handle chunks when they are finalized

ea1537a

Add 'availabilityTimeOffset'to DASH MPD for LL DASH streams

caa3fd3

Add 'duration' to SegmentTemplate and remove SegmentTimeline for LL D…

735cea5

…ASH MPD

Upload chunks via HTTP as they are created

99b442a

WIP: Manifest changes to pass LL DASH-IF validation

89bfc16

HTTP correction - add line that was accidentally deleted

465e7c6

WIP: Clean up the writing of each chunk

ac7ed90

Clean up chunk writing

debf467

Improve process of setting the 'duration' value for LL DASH MPD

ff5741d

Finalize serviceDescription implementation to satisfy IF-DASH LL stan…

8048867

…dards

Clean up code and logic

fa956ac

Improve MPD set segment duration implementation

7ea17dc

Change file_name scope to calculate it once per seg rather than calcu…

82ec563

…lating it for each chunk.

Better handle LL-DASH case within ChunkHandler and Segmenter

a064665

Clean up comments and naming

3242a68

Fix alignment

cc550f9

CaitlinOCallaghan added 20 commits August 24, 2021 17:24

Write ChunkingHandlerTest.LowLatencyDash unit test

a023b33

Write PeriodTest.LowLatencyDashMpdGetXml unit test

0edf8fe

Write MpdNotifyMuxerListenerTest.LowLatencyDash unit test

00f7b07

Write LowLatencySegmentTest.LowLatencySegmentTemplate unit test

efa1ca0

Format code

6f9fef3

Remove unnecessary line

0e88f2d

Specify value as float to pass 'Build and test win Debug shared' check

115657c

Restore line that was removed previously - it is necessary to include

29e2a32

Fixes to ChunkingHandlerTest.LowLatencyDash unittest

c8443eb

Change availabilityTimeOffset test value

5996805

Remove rounding on availabilityTimelineOffset for LL-DASH MPD

6cfe1bb

Add missing braket

98e2312

Change availabilityTimeOffset type from float to double

2791ca5

Format fix

7b7c348

LL-DASH flag name change

c4540c9

Low Latency DASH web documentation

1d7b941

Cleanup

46412b8

Account for LL-DASH name change

03564a7

Missing word fix

95db305

Add open source examples that support LL-DASH

8b168ec

CaitlinOCallaghan force-pushed the low-latency-dash-support-staging branch from e029d58 to 8b168ec Compare August 25, 2021 00:34

joeyparrish merged commit cd018a7 into shaka-project:master Aug 25, 2021

kevleyski reviewed Aug 25, 2021

View reviewed changes

github-actions bot added the status: archived Archived and locked; will not be updated label Jul 24, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Low latency DASH support #979

Low latency DASH support #979

CaitlinOCallaghan commented Aug 17, 2021 •

edited

Loading

googlebot commented Aug 17, 2021

google-cla bot commented Aug 17, 2021

CaitlinOCallaghan commented Aug 18, 2021 •

edited

Loading

kevleyski commented Aug 18, 2021

kqyang commented Aug 18, 2021

googlebot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

joeyparrish commented Aug 23, 2021

joeyparrish commented Aug 24, 2021

joeyparrish left a comment

kevleyski commented Aug 25, 2021 via email

CaitlinOCallaghan commented Aug 25, 2021

joeyparrish commented Aug 25, 2021

kevleyski commented Aug 25, 2021

kevleyski Aug 25, 2021

		@@ -126,6 +126,8 @@ class Segmenter {
		virtual Status DoFinalize() = 0;
		virtual Status DoFinalizeSegment() = 0;

Low latency DASH support #979

Low latency DASH support #979

Conversation

CaitlinOCallaghan commented Aug 17, 2021 • edited Loading

LL-DASH Support

Testing

Documentation

googlebot commented Aug 17, 2021

google-cla bot commented Aug 17, 2021

CaitlinOCallaghan commented Aug 18, 2021 • edited Loading

kevleyski commented Aug 18, 2021

kqyang commented Aug 18, 2021

PullRequest Sender

Commit Author(s)

googlebot commented Aug 23, 2021

google-cla bot commented Aug 23, 2021

joeyparrish commented Aug 23, 2021

joeyparrish commented Aug 24, 2021

joeyparrish left a comment

Choose a reason for hiding this comment

kevleyski commented Aug 25, 2021 via email

CaitlinOCallaghan commented Aug 25, 2021

joeyparrish commented Aug 25, 2021

kevleyski commented Aug 25, 2021

kevleyski Aug 25, 2021

Choose a reason for hiding this comment

CaitlinOCallaghan commented Aug 17, 2021 •

edited

Loading

CaitlinOCallaghan commented Aug 18, 2021 •

edited

Loading