Fix underwater volume scaling #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brilliant, the weather sound glitches were giving me headache! |
tewlwolow
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
underwaterCheck()would stop running once the player went underwater.registerModify()would unregister it and never re-register it. So, once underwater,modifyVolume()would run in an infinite loop in simulate, even when on land, continuously setting original volumes, and causing some weird sound glitches when the weather was changing.This PR fixes this issue and also introduces
playerHeightwhen calculating the new modified volume, for more accurate scaling. Now volume scaling will begin only when the player's head (playerPosZ+playerHeight) is below water level.Also disabling sliders for rain/extreme weather in our volume adjuster menu while underwater volume scaling is in effect, and informing the player of current scaled volume when the menu is being toggled on.
Aaaaaand some minor fixes/refactors. Tested, all ok, but lemme know if completely off rails here lel